Conversation
ksagiyam
force-pushed
the
ksagiyam/remove_mesh_init
branch
from
93bd80d to
a20b73d
Compare
ksagiyam
force-pushed
the
ksagiyam/remove_mesh_init
branch
3 times, most recently
from
3370faf to
d43d152
Compare
ksagiyam
force-pushed
the
ksagiyam/remove_mesh_init
branch
from
d43d152 to
528b546
Compare
ksagiyam
force-pushed
the
ksagiyam/remove_mesh_init
branch
14 times, most recently
from
a5616cc to
57f3349
Compare
ksagiyam
force-pushed
the
ksagiyam/remove_mesh_init
branch
4 times, most recently
from
9ba80c7 to
01e6515
Compare
dham
requested changes
Jul 9, 2025
connorjward
reviewed
Jul 9, 2025
ksagiyam
force-pushed
the
ksagiyam/remove_mesh_init
branch
from
01e6515 to
92870c4
Compare
connorjward
reviewed
Jul 10, 2025
Contributor
connorjward
left a comment
connorjward
left a comment
There was a problem hiding this comment.
I am basically very happy with this.
firedrake/mg/mesh.py
Outdated
| mesh_with_overlap = mesh | ||
| dm_cell_type, = mesh_with_overlap.dm_cell_types | ||
| tdim = mesh_with_overlap.topology_dm.getDimension() | ||
| # Effectively "invert" addOverlap(). This is algorithmically guaranteed. |
Contributor
There was a problem hiding this comment.
This isn't a particularly informative/clear comment.
ksagiyam
force-pushed
the
ksagiyam/remove_mesh_init
branch
from
aee09eb to
0d09227
Compare
Contributor
Author
|
@connorjward Slightly simplified notations according to the earlier changes. |
ksagiyam
force-pushed
the
ksagiyam/remove_mesh_init
branch
from
0d09227 to
e690ba1
Compare
connorjward
previously approved these changes
Jul 11, 2025
Contributor
connorjward
left a comment
connorjward
left a comment
There was a problem hiding this comment.
I'm happy with this.
ksagiyam
force-pushed
the
ksagiyam/remove_mesh_init
branch
from
e690ba1 to
5e62f09
Compare
Co-authored-by: Connor Ward <c.ward20@imperial.ac.uk>
ksagiyam
force-pushed
the
ksagiyam/remove_mesh_init
branch
2 times, most recently
from
c2120b5 to
69d26c3
Compare
Contributor
Author
|
CI passed except documentation links: https://github.com/firedrakeproject/firedrake/actions/runs/16443083990/job/46468241307. Merging. |
alexfikl
added a commit
to alexfikl/meshmode
that referenced
this pull request
Oct 5, 2025
inducer
pushed a commit
to inducer/meshmode
that referenced
this pull request
Oct 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove
mesh.init().We currently distribute mesh at mesh construction time, and later separately call
mesh.init()to add partition overlap. We add partition overlap separately as we want to do that after mesh refinement whenever refinement is needed. This means that we change state of the mesh object, which has caused confusion/inconvenience.In this PR we let mesh constructor fully construct the mesh (distribute + overlap), while reconstructing mesh without overlap from the overlapped mesh using
Submeshwherever necessary; i.e.,MeshHierarchynow takes overlapped mesh as argument.Requires:
PETSc:
https://gitlab.com/petsc/petsc/-/merge_requests/8353.Merged.https://gitlab.com/petsc/petsc/-/merge_requests/8539.Merged.ngsPETSc:
NGSolve/ngsPETSc#78.Merged.